Wikipedia:Bots/Requests for approval/OverlordQBot 6

The following discussion is an archived debate. Please do not modify it. Subsequent comments should be made in a new section. The result of the discussion was

Withdrawn by operator.

OverlordQBot 6[edit]

Operator: Q ^{T C}

Automatic or Manually Assisted: Automatic

Programming Language(s): Perl

Function Overview: Clean up Category:Tor_exit_nodes and related subcats.

Edit period(s): One Time Run

Already has a bot flag (Y/N): Y

Function Details: I want to do to clean out the Tor categories, get the categories of bans up to date, etc. Just basically clean up the mess that is the automagic tagging of Tor nodes. Below in the discussion of what it does, what it will do, and how it works.

Discussion[edit]

Original Proposed Format Hidden to Save Space

Raw debug output from a run (doing checks only, no modification):

overlordq@nightshade:~/$ ./checkIPs.pl
Bad: 1222
Good: 960
Total: 2182
Getting Blocked former nodes
------------------------------
NotExitNoBan: 116.20.201.72
NotExitNoBan: 116.21.97.171
NotExitNoBan: 116.22.33.66
...
NotExitNoBan: 134.34.147.22
NotExitNoBan: 134.48.216.45
NotExitNoBan: 134.48.217.19
NotExitNoBan: 134.48.217.8
NotExitNoBan: 134.60.221.22
NotExitStillBanned: 134.76.63.97
NotExitNoBan: 134.82.104.150
FormerActiveAgain: 134.91.236.5
NotExitNoBan: 137.112.145.75
NotExitNoBan: 137.99.150.25

For this category (Category:Blocked former Tor exit nodes):

NotExitNoBan means what the name says, so the tor template can be removed as it's neither a open tor node, nor is it banned.
NotExitStillBanned means that that IP is not an active exit node, but it is still banned.
FormerActiveAgain means that the IP has reactivated and needs recat'd into Category:Unblocked Tor exit nodes.

Getting unblocked Active
------------------------------
NotExitNoBan 114.199.100.12
NotExitNoBan 114.31.9.216
...
NotExitNoBan 125.116.31.243
IsExitIsBlocked 125.116.5.12
NotExitNoBan 125.118.198.51
NotExitNoBan 195.189.25.125
NotExitIsBlocked 195.24.77.134
IsExitIsBlocked 195.240.144.129

For this category (Category:Unblocked Tor exit nodes):

NotExitNoBan is the same as the above.
IsExitIsBlocked means that is an active Exit and is already blocked so needs recat'd into Category:Blocked Tor exit nodes.
NotExitIsBlocked means that there is a block on the IP, but it isn't a Tor node, so needs moved into Category:Blocked former Tor exit nodes

Getting blocked Active
------------------------------
NotExitNoBan 117.32.152.168
NotExitNoBan 124.217.247.103
NowFormerIsBlocked 125.33.138.52
NowFormerIsBlocked 137.226.113.2
NotExitNoBan 140.116.117.152
...
NowFormerIsBlocked 149.20.54.204
NotExitNoBan 158.130.5.102
IsExitIsBlocked 159.149.155.89
NowFormerIsBlocked 166.111.26.3
IsExitIsBlocked 166.70.207.2

For this category (Category:Blocked Tor exit nodes):

NotExitNoBan is same as the previous
NowFormerIsBlocked means the node is no longer active, but is banned, so needs moved into Category:Blocked former Tor exit nodes
IsExitIsBlocked means it is an active node and is still blocked, dont touch, just update timestamp on template tag.

These last two checks use the raw output from the Tor directory to check anything that isn't already listed

NotBannedIsActive 95.24.198.146
NotBannedIsActive 79.184.107.5
NotBannedIsActive 84.46.8.28
NotBannedIsActive 85.24.149.20
IsBannedNoList 78.142.140.194

For this check:

NotBannedIsActive means it's an active exit node but isn't blocked so needs added to Category:Unblocked Tor exit nodes
IsBannedNoList means that it's an active exit node but isn't categorized so needs added to Category:Blocked Tor exit nodes

NotBannedNotExit: 94.218.203.116
NotBannedNotExit: 213.239.197.38
NotExitStillBanned: 85.214.144.203
NotBannedNotExit: 62.149.203.82

For this check:

NotBannedNotExit means it doesnt exit to wikipedia, dont bother with it
NotExitStillBanned means it doesn't exit to wikipedia, but is banned, so categorize into Category:Blocked former Tor exit nodes

For all of these, the 'categorize into' and cat changing is done with the tor templates. For the banned but shouldn't, not banned but should will be output to a page for followup, as the former may be blocks that are not related to being a TOR exit.

If I'm forgetting any edge cases or have the logic messed up above, feel free to comment. Q ^{T C} 07:05, 24 March 2009 (UTC)[reply]

Alright, after the comments below, I feel that these categories are redundant and obsoleted by the TorBlock extension. As such, I feel the request should fulfill these tasks.

For all currently blocked IPs:

log them to a page for manual application of correct template {{open proxy}}, {{tor}}, {{etc...}}.

For all currently unblocked IPs:

If not a Tor node, remove the tor templates
If it is a Tor node, log to a seperate page for follow up.

The ratio of blocked/unblockedactive/unblockedinactive is about 2:3:95 Q ^{T C} 13:31, 26 March 2009 (UTC)[reply]

8 edit tests in the Recent changes. Forgot to tell it to do a test run instead of the real thing so it edited the actual pages instead of spit them to a log in userspace. :( Q ^{T C} 20:44, 25 March 2009 (UTC)[reply]

It's a replacement for KrimpBot for those confused. Q ^{T C} 10:03, 26 March 2009 (UTC)[reply]

User:KrimpBot has a lot of deleted contributions for a reason.... --MZMcBride (talk) 10:07, 26 March 2009 (UTC)[reply]

Is the reason that it was improperly tagging, or that tagging the talk pages was a bad idea? –xeno (talk) 12:52, 26 March 2009 (UTC)[reply]

I (think) the complaint was that it was creating talk pages, then blanking, creating, etc. I think these categories need retired, and this task should be relegated to a one-time run to make it accurate as TorBlock should be handling all of this already. Category tracking is pretty unnecessary at this point. Q ^{T C} 12:56, 26 March 2009 (UTC)[reply]

Modified the request. Q ^{T C} 13:31, 26 March 2009 (UTC)[reply]

The categories could be deprecated by removing them from the templates. –xeno (talk) 13:36, 26 March 2009 (UTC)[reply]

That'd be too easy. Q ^{T C} 13:37, 26 March 2009 (UTC)[reply]

Withdrawn by operator. Meh, I'll take this to WT:OP where we can figure out the best way outta this and refile later. Q ^{T C} 13:45, 26 March 2009 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. Subsequent comments should be made in a new section.