Talk:Trie/GA1

GA Review[edit]

Article (edit | visual edit | history) · Article talk (edit | history) · Watch

Reviewer: The Antediluvian (talk · contribs) 14:41, 17 April 2022 (UTC)[reply]

Rate	Attribute	Review Comment
1. Well-written:
	1a. the prose is clear, concise, and understandable to an appropriately broad audience; spelling and grammar are correct.	The article needs an "Overview" section that summarizes the functioning of the data structure, including why it should be used, and where it should be used and where not to. The lists within the "Applications" section needs to be expanded a little. Article should also need to provide information regarding time-space complexities on the body.
	1b. it complies with the Manual of Style guidelines for lead sections, layout, words to watch, fiction, and list incorporation.	Currently it needs minor copy editing for expressions like "don't", "doesn't", etc. A few sentences should also needs to be written in encyclopedic tone, specifically sections "Implementation strategies" and "Replacing other data structures". "Operations" section also needs copy editing.
2. Verifiable with no original research:
	2a. it contains a list of all references (sources of information), presented in accordance with the layout style guideline.	Article meets the verifiability criteria.
	2b. reliable sources are cited inline. All content that could reasonably be challenged, except for plot summaries and that which summarizes cited content elsewhere in the article, must be cited no later than the end of the paragraph (or line if the content is not in prose).	Article incorporates academic source.
	2c. it contains no original research.	Article meets WP:NOR criteria.
	2d. it contains no copyright violations or plagiarism.	Article meets this criteria.
3. Broad in its coverage:
	3a. it addresses the main aspects of the topic.	Article covers the general details regarding a trie that's required for a data structure article.
	3b. it stays focused on the topic without going into unnecessary detail (see summary style).	I think it gives undue weight to the "External memory tries" section, which should be merged or expanded. The phrasing is also unclear. Like I pointed out already, the article needs an "overview" section. The "Applications" section should also needs to be split into separate paragraphs.
	4. Neutral: it represents viewpoints fairly and without editorial bias, giving due weight to each.	Article is neutrally worded.
	5. Stable: it does not change significantly from day to day because of an ongoing edit war or content dispute.	No active disputes or edit-wars lately.
6. Illustrated, if possible, by media such as images, video, or audio:
	6a. media are tagged with their copyright statuses, and valid non-free use rationales are provided for non-free content.	The three images used in the article are tagged accordingly, and a summary is provided.
	6b. media are relevant to the topic, and have suitable captions.	Article meets this criteria.
	7. Overall assessment.	Currently the article does not meet the WP:GACR.

I am putting this article WP:GAN/I#HOLD. I will reassess the article once the following changes were made. The Antediluvian 15:25, 17 April 2022 (UTC)[reply]

Thanks for taking this. I'll make the requested changes soon. --WikiLinuz {talk} 🍁 15:57, 17 April 2022 (UTC)[reply]

I've addressed the points 1 and 3b. --WikiLinuz {talk} 🍁 22:52, 17 April 2022 (UTC)[reply]

I have reassessed the article. Can you please mention the time and space complexities of tries in the lead section? Currently, there doesn't seem to be a sentence talking about that information. The Antediluvian 09:27, 18 April 2022 (UTC)[reply]

Yeah, I've added that. --WikiLinuz {talk} 🍁 22:31, 18 April 2022 (UTC)[reply]

Thankyou. I will approve the article. Best regards, The Antediluvian 22:38, 18 April 2022 (UTC)[reply]