Wikipedia:Bots/Requests for approval/DannyS712 bot 23

Add links
From Wikipedia, the free encyclopedia
The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

DannyS712 bot 23[edit]

Operator: DannyS712 (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 19:13, Wednesday, March 20, 2019 (UTC)

Automatic, Supervised, or Manual: automatic

Programming language(s): AWB

Source code available: AWB

Function overview: Extend task 22 to other templates from the same TfD

Links to relevant discussions (where appropriate): WP:Bots/Requests for approval/DannyS712 bot 22 and the discussions linked there

Edit period(s): One time run

Estimated number of pages affected: Up to ~7000 (some may overlap) 2134 ([1])

Exclusion compliant (Yes/No): No

Already has a bot flag (Yes/No): Yes

Function details:

Original (outdated) request

Removesubstitute {{PBB_Summary}}. Only removed its html comment (and its inline html comment) - 3543 transclusions

Substitute {{PBB Further reading}} - 3539 transclusions (not deletion since its just a wrapper for citations that should be kept
  • Substitute {{PBB Summary}}
  • Remove the html comment associated with it

Discussion[edit]

Outdated discussion
  • Zackmann08 is doing this using AWB already. {{3x|p}}ery (talk) 19:14, 20 March 2019 (UTC)[reply]
    @Pppery: I can help, given the number - see User talk:DannyS712#Your BRFA (22) for the discussion causing me to file this --DannyS712 (talk) 19:18, 20 March 2019 (UTC)[reply]
    Makes sense. I didn't notice task 22 et al until after posting that comment. {{3x|p}}ery (talk) 19:19, 20 March 2019 (UTC)[reply]
  • The content of {{PBB Summary}} is text that needs to be kept. Galobtter (pingó mió) 19:18, 20 March 2019 (UTC)[reply]
    @Galobtter: in that case, I can substitute both of the templates --DannyS712 (talk) 19:19, 20 March 2019 (UTC)[reply]
    DannyS712 & Pppery, No objection to a bot taking this over! I'll gladly duck out once this is approved! Zackmann (Talk to me/What I been doing) 20:04, 20 March 2019 (UTC)[reply]
  • Pinging @MarnetteD: to this as he was manually doing one of those templates, but was ok with a bot to take over. --Gonnym (talk) 20:14, 20 March 2019 (UTC)[reply]
    Thanks for the ping. Actually I was doing "summary" and "further reading" at the same time on most of my edits. Remember that all of the items in further reading need to stay just like the summary does. I'm guessing you already know this but I mention it just in case. MarnetteD|Talk 20:19, 20 March 2019 (UTC)[reply]
    @MarnetteD: Yes. Except, I just realized, while substituting further reading works great (Special:Diff/888699322), substituting the summary doesn't really (Special:Diff/888699171), so when I saw "substitute" the summary template, I mean replace it using a regex to achieve the intended display, not literally "substitute" the template, since that keeps the parser functions and everything. --DannyS712 (talk) 20:25, 20 March 2019 (UTC)[reply]
    Thanks D! I'm not too familiar with all the ins and outs of bots so I appreciate your taking the time to explain things. MarnetteD|Talk 20:28, 20 March 2019 (UTC)[reply]
    DannyS712, I've made the summary template cleanly subst. Galobtter (pingó mió) 20:34, 20 March 2019 (UTC)[reply]

@Galobtter: Wow, I just developed a regex to do it without substituting, but I guess its all useless now. Anyway, just subst the templates and remove the inline comments. If anyone cares, the regex was:

Extended content
{{PBB[ _]Summary\n\|\s+section_title\s+=\s+\|\s+summary_text\s+=\s+(.*)\n}}

becomes 

$1

and 

{{PBB[ _]Summary\n\|\s+section_title\s+=\s+(\S+)\n\|\s+summary_text\s+=\s+(.*)\n}}

becomes 

==$1==\n$2

(first regex for not having a section title, second for having one).

Anyway, I think this is good to go: substitute both templates, and remove the html comment. Thanks for the help, --DannyS712 (talk) 20:45, 20 March 2019 (UTC)[reply]

DannyS712, get er doneeee!!! Zackmann (Talk to me/What I been doing) 19:15, 22 March 2019 (UTC)[reply]
  • One template done but the other still has over 2k uses. Is there any reason this has not gotten any response, even for a trial? --Gonnym (talk) 22:11, 31 March 2019 (UTC)[reply]
    @Gonnym: I had too many BRFAs at once, so this was removed from the main page. I'm hoping to add it again in the next few days, since I have 3 trials complete. --DannyS712 (talk) 22:13, 31 March 2019 (UTC)[reply]
    @Gonnym and Zackmann08: I've re-transcluded it --DannyS712 (talk) 03:45, 4 April 2019 (UTC)[reply]
    In the hopes of getting this task approved quickly (maybe speedy approval?) I ran a "trial" with my main account - every edit was reviewed manually before saving. See the 25 "trial" edits: [2] (I chose 25 because that is what the trial amount was for task #22). The code was:
    1. Find <!-- The PBB_Summary template is automatically maintained by Protein Box Bot. See Template:PBB_Controls to Stop updates. --> and replace it with an empty string
    2. Find {{PBB( |_)Summary (a regex pattern) and replace it with {{subst:PBB Summary
    Thanks, --DannyS712 (talk) 23:29, 6 April 2019 (UTC)[reply]
Approved for trial (50 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. — xaosflux Talk 13:44, 7 April 2019 (UTC)[reply]
@Xaosflux: Trial complete. 50 edits made [3]. I didn't see any issues. Thanks, --DannyS712 (talk) 17:43, 7 April 2019 (UTC)[reply]
@DannyS712: in these edits, you left the HTML comment behind (maybe it has a one-off letter or something, but it doesn't belong for sure): 1 2. Please review and see if you can identify a way to improve this (You can have 20 more trial edits if needed). — xaosflux Talk 18:24, 7 April 2019 (UTC)[reply]
@Xaosflux: The HTML comment generally had 2 spaces between the sentences, but those only had one, so it was one character off. I have changed the first find-and-replace to be a regex: <!-- The PBB_Summary template is automatically maintained by Protein Box Bot\. ?See Template:PBB_Controls to Stop updates\. -->, which works with 1 or 2 spaces. See the 2 edits made: [4] [5]. Thanks, --DannyS712 (talk) 19:30, 7 April 2019 (UTC)[reply]
 Approved. task approved. — xaosflux Talk 21:33, 7 April 2019 (UTC)[reply]
The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.
Retrieved from "https://en.wikipedia.org/w/index.php?title=Wikipedia:Bots/Requests_for_approval/DannyS712_bot_23&oldid=891423394"